Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Thumgeon button code to use API #99

Closed
ace-dent opened this issue Sep 7, 2023 · 3 comments
Closed

Update Thumgeon button code to use API #99

ace-dent opened this issue Sep 7, 2023 · 3 comments

Comments

@ace-dent
Copy link
Contributor

ace-dent commented Sep 7, 2023

As a 'core' game, Thumgeon should use the Thumby API where possible; in part for best practice/ education.
The custom button handling code should be replaced with API equivalents.
This also avoids the extra import of Pin from machine.
@ace-dent
Copy link
Contributor Author

ace-dent commented Sep 8, 2023

Corresponding issue for Arcade Repo is here.

@ace-dent ace-dent mentioned this issue Sep 8, 2023
Open
@ghost
Copy link

ghost commented Sep 28, 2023 •
edited by ghost
Loading

I removed the base games from this repository in 38fc1b8, now they're just on the Arcade https://github.com/TinyCircuits/TinyCircuits-Thumby-Games.

This and #97 shouldn't be needed here anymore.

@ace-dent
Copy link
Contributor Author

ace-dent commented Sep 28, 2023 •
edited
Loading

Thanks @jmtinycircuits . Appreciate this!
Issue is now just with the Arcade version. Closing duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ace-dent