javadoc + reordered methods

Author: interacsion

application/src/main/java/org/togetherjava/tjbot/commands/moderation/temp/RevocableRoleBasedAction.java

@@ -5,11 +5,23 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+/**
+ * {@link RevocableModerationAction} abstract implementation for a role based moderation action.
+ * <br />
+ * <br />
+ * Implements {@link RevocableModerationAction#handleRevokeFailure(ErrorResponse, long)} to handle
+ * possible errors for a role-based revocation action.
+ */
 abstract class RevocableRoleBasedAction implements RevocableModerationAction {
     private static final Logger logger = LoggerFactory.getLogger(RevocableRoleBasedAction.class);
 
     private final String actionName;
 
+    /**
+     * Creates an instance of {@link RevocableRoleBasedAction} with the given action name.
+     *
+     * @param actionName the name of the moderation action
+     */
     RevocableRoleBasedAction(String actionName) {
         this.actionName = actionName;
     }

application/src/main/java/org/togetherjava/tjbot/commands/moderation/temp/TemporaryModerationRoutine.java

@@ -126,6 +126,19 @@ private void revokeAction(@NotNull RevocationGroupIdentifier groupIdentifier) {
             }, failure -> handleFailure(failure, groupIdentifier));
     }
 
+    private @NotNull RestAction<Void> executeRevocation(@NotNull Guild guild, @NotNull User target,
+            @NotNull ModerationAction actionType) {
+        logger.info("Revoked temporary action {} against user '{}' ({}).", actionType,
+                target.getAsTag(), target.getId());
+        RevocableModerationAction action = getRevocableActionByType(actionType);
+
+        String reason = "Automatic revocation of temporary action.";
+        actionsStore.addAction(guild.getIdLong(), jda.getSelfUser().getIdLong(), target.getIdLong(),
+                action.getRevokeType(), null, reason);
+
+        return action.revokeAction(guild, target, reason);
+    }
+
     private void handleFailure(@NotNull Throwable failure,
             @NotNull RevocationGroupIdentifier groupIdentifier) {
         if (failure instanceof ErrorResponseException errorResponseException
@@ -140,19 +153,6 @@ private void handleFailure(@NotNull Throwable failure,
                 groupIdentifier.targetId, failure);
     }
 
-    private @NotNull RestAction<Void> executeRevocation(@NotNull Guild guild, @NotNull User target,
-            @NotNull ModerationAction actionType) {
-        logger.info("Revoked temporary action {} against user '{}' ({}).", actionType,
-                target.getAsTag(), target.getId());
-        RevocableModerationAction action = getRevocableActionByType(actionType);
-
-        String reason = "Automatic revocation of temporary action.";
-        actionsStore.addAction(guild.getIdLong(), jda.getSelfUser().getIdLong(), target.getIdLong(),
-                action.getRevokeType(), null, reason);
-
-        return action.revokeAction(guild, target, reason);
-    }
-
     private @NotNull RevocableModerationAction getRevocableActionByType(
             @NotNull ModerationAction type) {
         return Objects.requireNonNull(typeToRevocableAction.get(type),