added not-null checks for fail-fast

Author: Zabuzard

application/src/main/java/org/togetherjava/tjbot/commands/moderation/BanCommand.java

@@ -61,7 +61,7 @@ public BanCommand(@NotNull ModerationActionsStore actionsStore) {
 
         hasRequiredRole = Pattern.compile(Config.getInstance().getHeavyModerationRolePattern())
             .asMatchPredicate();
-        this.actionsStore = actionsStore;
+        this.actionsStore = Objects.requireNonNull(actionsStore);
     }
 
     private static RestAction<InteractionHook> handleAlreadyBanned(@NotNull Guild.Ban ban,

application/src/main/java/org/togetherjava/tjbot/commands/moderation/KickCommand.java

@@ -51,7 +51,7 @@ public KickCommand(@NotNull ModerationActionsStore actionsStore) {
 
         hasRequiredRole = Pattern.compile(Config.getInstance().getSoftModerationRolePattern())
             .asMatchPredicate();
-        this.actionsStore = actionsStore;
+        this.actionsStore = Objects.requireNonNull(actionsStore);
     }
 
     private static void handleAbsentTarget(@NotNull Interaction event) {

application/src/main/java/org/togetherjava/tjbot/commands/moderation/ModerationActionsStore.java

@@ -9,6 +9,7 @@
 
 import java.time.Instant;
 import java.util.List;
+import java.util.Objects;
 import java.util.Optional;
 
 /**
@@ -36,7 +37,7 @@ public final class ModerationActionsStore {
      * @param database the database to write and retrieve actions from
      */
     public ModerationActionsStore(@NotNull Database database) {
-        this.database = database;
+        this.database = Objects.requireNonNull(database);
     }
 
     /**
@@ -50,6 +51,8 @@ public ModerationActionsStore(@NotNull Database database) {
      */
     public @NotNull List<ActionRecord> getActionsByTypeAscending(long guildId,
             @NotNull ModerationUtils.Action actionType) {
+        Objects.requireNonNull(actionType);
+
         return getActionsFromGuildAscending(guildId,
                 ModerationActions.MODERATION_ACTIONS.ACTION_TYPE.eq(actionType.name()));
     }
@@ -118,6 +121,9 @@ public ModerationActionsStore(@NotNull Database database) {
     public int addAction(long guildId, long authorId, long targetId,
             @NotNull ModerationUtils.Action actionType, @Nullable Instant actionExpiresAt,
             @NotNull String reason) {
+        Objects.requireNonNull(actionType);
+        Objects.requireNonNull(reason);
+
         return database.writeAndProvide(context -> {
             ModerationActionsRecord actionRecord =
                     context.newRecord(ModerationActions.MODERATION_ACTIONS)
@@ -135,6 +141,8 @@ public int addAction(long guildId, long authorId, long targetId,
 
     private @NotNull List<ActionRecord> getActionsFromGuildAscending(long guildId,
             @NotNull Condition condition) {
+        Objects.requireNonNull(condition);
+
         return database.read(context -> context.selectFrom(ModerationActions.MODERATION_ACTIONS)
             .where(ModerationActions.MODERATION_ACTIONS.GUILD_ID.eq(guildId).and(condition))
             .orderBy(ModerationActions.MODERATION_ACTIONS.ISSUED_AT.asc())

application/src/main/java/org/togetherjava/tjbot/commands/moderation/UnbanCommand.java

@@ -46,7 +46,7 @@ public UnbanCommand(@NotNull ModerationActionsStore actionsStore) {
 
         hasRequiredRole = Pattern.compile(Config.getInstance().getHeavyModerationRolePattern())
             .asMatchPredicate();
-        this.actionsStore = actionsStore;
+        this.actionsStore = Objects.requireNonNull(actionsStore);
     }
 
     private void unban(@NotNull User target, @NotNull Member author, @NotNull String reason,