Skip to content

Note command lacks safety checks in onSlashCommand like BanCommand #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonVerhoeven opened this issue Apr 13, 2024 · 2 comments · Fixed by #1086
Closed

Note command lacks safety checks in onSlashCommand like BanCommand #1085

SimonVerhoeven opened this issue Apr 13, 2024 · 2 comments · Fixed by #1086
Labels
bug Something isn't working

Comments

@SimonVerhoeven
Copy link
Contributor

Describe the bug
Note command lacks safety checks in onSlashCommand like BanCommand

Expected behavior
For the checks to be present

To Reproduce

Screenshots

Additional context
@SimonVerhoeven SimonVerhoeven added the bug Something isn't working label Apr 13, 2024
@SimonVerhoeven SimonVerhoeven mentioned this issue Apr 13, 2024
Merged
@ankitsmt211
Copy link
Member

shouldn't we use discord's inbuilt required arguement instead? It would educate the user and stop the command from execution.

@SimonVerhoeven
Copy link
Contributor Author

In the AddOption they're already marked as required true to educate the user, but the handling (onSlashCommand) was inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add safety checks to NoteCommand SimonVerhoeven/TJ-Bot
2 participants
@SimonVerhoeven @ankitsmt211