Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in documentation #15

Open
Petr-Hlavenka opened this issue Mar 24, 2020 · 8 comments
Open

Example in documentation #15

Petr-Hlavenka opened this issue Mar 24, 2020 · 8 comments

Comments

@Petr-Hlavenka
Copy link

Please, could you include the example in AxisArrays.jl readme, that would show an implementation of a time-domain "WaveformArray", with time axis in unitful::seconds. And demonstrating, how an Interval indexing can be implemented.
A[40µs .. 220µs, :c1].
Right now, the example with Dates.second is kind of too difficult and emphasis the "new" stuff, but does not demonstrate the obvious indexing usecase.
Thank you a lot

@Tokazama
Copy link
Owner

I have an example that I will put in the docs once this PR fixing a bug in Unitful is merged

@Tokazama
Copy link
Owner

I just realized I hadn't followed up on this. The necessary fix for this was just merged into Unitful yesterday. I'm waiting to release an update to registry until this weekend because I want to incorporate changes relative to ronisbr/PrettyTables.jl#18 (comment), which will likely result in a breaking change for this package as well.

@ronisbr
Copy link

ronisbr commented Apr 11, 2020

Hi @Tokazama

Can you please test my latest commit in master? The formatters API has changed significantly, but I tried to add a warning message and a conversion to avoid too much breakage.

@Tokazama
Copy link
Owner

Tokazama commented Apr 12, 2020

Just tried it and it seems to work really well. I haven't robustly tested it but it look like it's already going to save me a bunch of pretty messy code on my end.

How do I set header_line = false now?
EDIT: Nevermind, figured it out.

@ronisbr
Copy link

ronisbr commented Apr 12, 2020

Good! Thanks :)

Just need to document a bit and I will release today.

@Tokazama
Copy link
Owner

@ronisbr , What's that status on the new release?

@ronisbr
Copy link

ronisbr commented Apr 13, 2020

Hi @Tokazama!

Sorry, things are not going fine here. I had a problem and need to completely format my PC :( I am finishing to install everything. I will release today!

@ronisbr
Copy link

ronisbr commented Apr 14, 2020

Done! Should be merged soon! Sorry for the delay.

JuliaRegistries/General#12904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants