Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeGenerated collision has extra lip #328

Closed
TokisanGames opened this issue Feb 26, 2024 · 1 comment
Closed

CodeGenerated collision has extra lip #328

TokisanGames opened this issue Feb 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TokisanGames
Copy link
Owner

Description

The code generated scene has an extra collision lip, though it is not present in the non-code generated demo. 0.9.1-beta.

image

@TokisanGames TokisanGames added the bug Something isn't working label Feb 26, 2024
@TokisanGames TokisanGames added this to the Beta 0.9.x milestone Feb 26, 2024
@TokisanGames TokisanGames moved this from 0.9.2 to 0.9.3 in Terrain3D Roadmap May 23, 2024
@TokisanGames TokisanGames modified the milestones: 0.9, 1.0 Oct 6, 2024
@TokisanGames TokisanGames self-assigned this Oct 6, 2024
@TokisanGames TokisanGames moved this from 1.0 to In Progress in Terrain3D Roadmap Dec 31, 2024
@TokisanGames
Copy link
Owner Author

The demo noise makes the terrain dip below 0 on the +X,+Z edges.

The collision lip is caused by _update_collision where it assumes the next +x and +z map values are 0 if they don't exist. On the +X,+Z edge of the world, the next maps don't exist, so 0 is used. In the current version, the shader also matches the collision so there are both visual and collision lips. We could fix collision easily by using the last height, but it's not so easy for the shader. So, now that they match, I won't change them.

What I will do is increase the height of the demo terrain so it is above 0 on the +X, +Z edges. Completed in fba0242

@github-project-automation github-project-automation bot moved this from In Progress to Done in Terrain3D Roadmap Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant