Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: List style doesn't highlight items in shopping list #221

Closed
pizzapim opened this issue Aug 12, 2023 · 2 comments · Fixed by #231
Closed

Bug: List style doesn't highlight items in shopping list #221

pizzapim opened this issue Aug 12, 2023 · 2 comments · Fixed by #231
Labels
bug Something isn't working

Comments

@pizzapim
Copy link
Contributor

Is this urgent?

No

What parts are affected

Frontend

What are the Server/Client versions of KitchenOwl

backend v75 docker image, android app v0.4.8

What's the problem 🤔

If I change my setting of Shopping list style to List, the items on my shopping list are no longer highlighted in bright green. This is quite confusing.

image
image

Share your logs

No response

Share your configuration

No response

@pizzapim pizzapim added the bug Something isn't working label Aug 12, 2023
@TomBursch
Copy link
Owner

Hmm yeah I get why it's confusing, but it just looked really weird when I tried it with all of them green/selected. There is also an issue about inconsistency #179. I'll add it to my list to redo/rethink. I hope I'll have time for that and this issue next month.

@pizzapim
Copy link
Contributor Author

Thanks. I also showed this app to my mother, and she was a bit confused about the shopping list page as well. When you have ticked off every item, you are left with only gray items but she thought they were all on the list still. Maybe making the text grayed-out as well makes it more clear they are not currently on the list.

@TomBursch TomBursch linked a pull request Aug 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants