Bug: encrypting/decrypting large integers results in mismatched digits

[psvet]

Found when trying to store a Salesforce client secret.

Here's an example using a 19-digit integer (the length of the client secret):

Notice the 400 ending the decrypted string, versus the 500 of the original. The same thing occurs using getsecret after storing the string in the config file.

Compare that with appending a letter to the integer, which works as expected:

[TomFrost]

Replicated using the plaintext algorithm... this is wild:

╭─<tom@tom-ta>-<~/Projects/Cryptex>-<1bf19ad∙master∙▪>-<9:43PM>-◇
╰─➤ node src/cli.js encrypt 1234567890123400500
1234567890123400400

[TomFrost]

Looks like the issue is Javascript, rounding longs big-endian style.

> const int = 123456789012340045
undefined
> int
123456789012340050

[TomFrost]

The underlying issue is yargs parsing too-long numbers as a number instead of a string. Bug report logged here: yargs/yargs#550

In absence of any near-term motion on that ticket, I'll write a workaround that manually parses encrypt arguments from the original process.argv.

[TomFrost]

Fixed in v1.0.0. Thanks, yargs team!