Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check ignored files #10

Closed
borekb opened this issue Aug 27, 2018 · 5 comments
Closed

Don't check ignored files #10

borekb opened this issue Aug 27, 2018 · 5 comments
Assignees

Comments

@borekb
Copy link

borekb commented Aug 27, 2018

@TomasHubelbauer

The paths on the following screenshot are gitignored in our repo but still checked by this extension:

image

Is that possibly related to some deeper VSCode issue, like microsoft/vscode#50874?

@TomasHubelbauer TomasHubelbauer self-assigned this Sep 2, 2018
@TomasHubelbauer
Copy link
Owner

Thank you, I will check this and see if I can improve detecting ignored files a bit more, VS Code API seems to be a little spotty when it comes to this indeed, but I believe I will be able to come up with a working solution nontheless. I think I will be able to fix this this upcoming weekend.

@TomasHubelbauer
Copy link
Owner

Once again, thank you for reporting this. I have decided to prioritize internal rewrite which should help enable some new features I have in mind and make future work easier over fixing this at this time in an interest of best allocating the time I can give this extension. I hope it's not a problem to wait for this a bit longer, if it significantly breaks your workflow, I'll revert that decision and focus on a hotfix for this in the current codebase.

@borekb
Copy link
Author

borekb commented Sep 13, 2018

It's not critical for my workflow and am happy to wait for a newer and even more awesome version :)

@TomasHubelbauer
Copy link
Owner

This should be fixed in 12.0.3 using the workaround described in my latest comment in microsoft/vscode#48674.

I am worried that code might be a little bit unstable, I wish VS Code had better SCM API which could be used to query file status.

I will keep monitoring Application Insights for failures coming from that logic, but it defaults to providing files from potentially ignored directories, so from the user PoV it should always do something reasonable.

Worst case it could just keep finding diagnostics issues in your ignored file, but hopefully it doesn't anymore. I will leave this open for a bit in case this release won't go as smoothly as I am hoping it will.

@borekb
Copy link
Author

borekb commented Sep 20, 2018

At first sight, it seems that this helped – I no longer see suggestions from ignored files. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants