Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaglue namespace #40

Open
JMLX42 opened this issue Jan 13, 2014 · 4 comments
Open

luaglue namespace #40

JMLX42 opened this issue Jan 13, 2014 · 4 comments

Comments

@JMLX42
Copy link
Contributor

JMLX42 commented Jan 13, 2014

Hello,

there is no luaglue namespace; it would be definitely better than prefixing all classes. The biggest problem is some global definitions that might collide with other libs.

Are you ok to add a luaglue namespace?

Regards,

@Tomasu
Copy link
Owner

Tomasu commented Jan 14, 2014

Yeah, see issue #6 . I'll do it soonish.

@JMLX42
Copy link
Contributor Author

JMLX42 commented Jan 14, 2014

Nothing in common with #6. I'm talking about namespacing the LuaGlue* classes.
Ex: luaglue::Class instead of LuaGlueClass.

@Tomasu
Copy link
Owner

Tomasu commented Jan 14, 2014

I'm not aware of any globals that can conflict? If you mean macros, they can't be namespaced.

namespacing might be in the cards.

@JMLX42
Copy link
Contributor Author

JMLX42 commented Jan 14, 2014

I had to add remove_const custom meta functions to make it work with VS (incoming pull request btw).
I named them luaglue_remove_const which is quite ugly don't you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants