Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check convergence in PDHG throws an error, and should be False by default #1965

Closed
MargaretDuff opened this issue Oct 22, 2024 · 1 comment · Fixed by #2010
Closed

Check convergence in PDHG throws an error, and should be False by default #1965

MargaretDuff opened this issue Oct 22, 2024 · 1 comment · Fixed by #2010
Assignees
@MargaretDuff
Labels
bug Something isn't working

Comments

@MargaretDuff
Copy link
Member

MargaretDuff commented Oct 22, 2024 •
edited
Loading

Description

The continued mission to kill kwargs... we should delete these line:
https://github.com/TomographicImaging/CIL/blob/23187c9eebfc691a4d65178c37a6cf59b01a0d57/Wrappers/Python/cil/optimisation/algorithms/PDHG.py#L320C7-L321C37
@MargaretDuff MargaretDuff added the bug Something isn't working label Oct 22, 2024
@MargaretDuff MargaretDuff self-assigned this Oct 22, 2024
@lauramurgatroyd lauramurgatroyd changed the title Check convergence in PDHG should be optional Check convergence in PDHG throws an error, and should be optional Oct 22, 2024
@MargaretDuff MargaretDuff changed the title Check convergence in PDHG throws an error, and should be optional Check convergence in PDHG throws an error, and shouldn't default to True Oct 22, 2024
@lauramurgatroyd lauramurgatroyd changed the title Check convergence in PDHG throws an error, and shouldn't default to True Check convergence in PDHG throws an error, and should be False by default Oct 22, 2024
@lauramurgatroyd
Copy link
Member

check_convergence currently isn't usable because:

CIL/Wrappers/Python/cil/optimisation/algorithms/PDHG.py

Line 225 in 23187c9

super().__init__(**kwargs)

passes it to the Algorithm base class which throws an error:
Algorithm.init() got an unexpected keyword argument 'check_convergence'

@lauramurgatroyd lauramurgatroyd mentioned this issue Oct 22, 2024
Open
@MargaretDuff MargaretDuff mentioned this issue Dec 11, 2024
Merged
9 tasks
@MargaretDuff MargaretDuff linked a pull request Dec 11, 2024 that will close this issue
Fix kwargs in PDHG #2010
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MargaretDuff MargaretDuff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix kwargs in PDHG TomographicImaging/CIL
2 participants
@MargaretDuff @lauramurgatroyd