Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_SPDHG_vs_PDHG_explicit test is unreliable #2014

Open
lauramurgatroyd opened this issue Dec 12, 2024 · 0 comments · May be fixed by #2019
Open

test_SPDHG_vs_PDHG_explicit test is unreliable #2014

lauramurgatroyd opened this issue Dec 12, 2024 · 0 comments · May be fixed by #2019
Assignees
Labels
bug Something isn't working

Comments

@lauramurgatroyd
Copy link
Member

lauramurgatroyd commented Dec 12, 2024

Description

In a PR where I only changed docstrings this test failed

FAIL: test_SPDHG_vs_PDHG_explicit (test_algorithms.TestSPDHG)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda/envs/test/conda-bld/cil_1733995110980/test_tmp/Wrappers/Python/test/test_algorithms.py", line 1535, in test_SPDHG_vs_PDHG_explicit
    np.testing.assert_almost_equal(mae(spdhg.get_output(), pdhg.get_output()),
  File "/usr/share/miniconda/envs/test/conda-bld/cil_1733995110980/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.10/site-packages/numpy/testing/_private/utils.py", line 599, in assert_almost_equal
    raise AssertionError(_build_err_msg())
AssertionError: 
Arrays are not almost equal to 3 decimals
 ACTUAL: 0.00545253
 DESIRED: 0.0031962995

Environment

CIL master - github action for PR - action is conda (3.10, 1.23)
https://github.com/TomographicImaging/CIL/actions/runs/12293300385/attempts/1

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)
@lauramurgatroyd lauramurgatroyd added the bug Something isn't working label Dec 12, 2024
@MargaretDuff MargaretDuff self-assigned this Dec 12, 2024
@MargaretDuff MargaretDuff linked a pull request Dec 18, 2024 that will close this issue
9 tasks
@MargaretDuff MargaretDuff linked a pull request Dec 18, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants