Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When conda building, get "Built wheel for ccpi-viewer is invalid" error #333

Closed
lauramurgatroyd opened this issue Jan 17, 2023 · 0 comments · Fixed by #334
Closed

When conda building, get "Built wheel for ccpi-viewer is invalid" error #333

lauramurgatroyd opened this issue Jan 17, 2023 · 0 comments · Fixed by #334
Labels

Comments

@lauramurgatroyd
Copy link
Member

When we run actions we consistently get this:
https://github.com/vais-ral/CILViewer/actions/runs/3524392336/jobs/5909735176#step:4:587

WARNING: Built wheel for ccpi-viewer is invalid: Metadata 1.2 mandates PEP 440 version, but '22.4.0-26-gd763c8c' is not
DEPRECATION: ccpi-viewer was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at pypa/pip#8368

I believe we need to move this line:
https://github.com/vais-ral/CILViewer/blob/9ebd5ea3246007e1267cf9298f61a75ea3c73304/Wrappers/Python/setup.py#L48
out of the if statement so that we are always converting the version to pep440 compatible. Currently it only happens if we aren't conda building.

What was the original reason behind only converting this if we aren't conda building?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant