Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Adding Custom Saber to already installed Map breaks Scoring / Playlists #125

Open
vlntnwbr opened this issue Mar 9, 2022 · 2 comments

Comments

@vlntnwbr
Copy link

vlntnwbr commented Mar 9, 2022

When adding a _customSaber: "Plasma Katana" property to the Info.dat file of an already installed BeatMap it is no longer recognized as a part of a playlist. Previously achieved scores are also no longer detected. I assume this happens because the Map data was changed which is handled by considering it to be a new map.

Proposed Solution

Add an optional json file, e.g. LevelSaberMapping.json to the CustomSabers folder in order to assign custom sabers to already installed levels. The json key could be the BeatSaver Hash or Key of the desired level, the value would be the name of the desired Saber (identical to the expected value of the already implemented _customSaber property of a Map.

This would make it possible to assign custom sabers to levels without modifying the level data which in turn should fix the issues with detecting the level for scoring and playlist purposes.

@ToniMacaroni
Copy link
Owner

I will implement the proposed solution in the next version

@vlntnwbr
Copy link
Author

Thank you. I will report back once I'm able to test it. As I said, I don't really know whether my proposed solution actually fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants