Support for node-v0.11.x?

[tony612]

Is there any plan to add nan to support the new node version?

[TooTallNate]

Yes definitely! Just have to find some spare time to upgrade the code base. Patches welcome of course!

[tony612]

@TooTallNate Cool. I'm happy to patch, but I'm new to node, so maybe it's not easy for me to do this..

[q2dg]

Well...in v0.11.14 I get these errors trying to install this module via npm:

lame@1.1.1 install /home/q2dg/node_modules/lame
node-gyp rebuild

child_process: customFds option is deprecated, use stdio instead.
make: Entering directory /home/q2dg/node_modules/lame/build' deps/mpg123/test.target.mk:119: warning: overriding recipe for targetRelease/test'
deps/lame/test.target.mk:127: warning: ignoring old recipe for target Release/test' CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/VbrTag.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/bitstream.o ../deps/lame/libmp3lame/bitstream.c: In function ‘do_gain_analysis’: ../deps/lame/libmp3lame/bitstream.c:992:24: warning: unused variable ‘rov’ [-Wunused-variable] RpgResult_t *const rov = &gfc->ov_rpg; ^ ../deps/lame/libmp3lame/bitstream.c:991:32: warning: unused variable ‘rsv’ [-Wunused-variable] RpgStateVar_t const *const rsv = &gfc->sv_rpg; ^ ../deps/lame/libmp3lame/bitstream.c:990:34: warning: unused variable ‘cfg’ [-Wunused-variable] SessionConfig_t const *const cfg = &gfc->cfg; ^ CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/encoder.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/fft.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/gain_analysis.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/id3tag.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/lame.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/newmdct.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/presets.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/psymodel.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/quantize.o ../deps/lame/libmp3lame/quantize.c: In function ‘VBR_new_iteration_loop’: ../deps/lame/libmp3lame/quantize.c:1734:24: warning: variable ‘fullframebits’ set but not used [-Wunused-but-set-variable] int mean_bits, fullframebits; ^ CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/quantize_pvt.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/reservoir.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/set_get.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/tables.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/takehiro.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/util.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/vbrquantize.o CC(target) Release/obj.target/mp3lame/deps/lame/libmp3lame/version.o AR(target) Release/obj.target/deps/lame/libmp3lame.a COPY Release/libmp3lame.a CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/compat.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/parse.o ../deps/mpg123/src/libmpg123/parse.c: In function ‘check_lame_tag’: ../deps/mpg123/src/libmpg123/parse.c:184:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(fr->track_frames > TRACK_MAX_FRAMES) fr->track_frames = 0; /* endless stream? */ ^ ../deps/mpg123/src/libmpg123/parse.c: In function ‘handle_id3v2’: ../deps/mpg123/src/libmpg123/parse.c:1013:7: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] else debug("no useful ID3v2"); ^ ../deps/mpg123/src/libmpg123/parse.c: In function ‘skip_junk’: ../deps/mpg123/src/libmpg123/parse.c:1081:7: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] else debug1("hopefully found one at %"OFF_P, (off_p)fr->rd->tell(fr)); ^ ../deps/mpg123/src/libmpg123/parse.c: In function ‘wetwork’: ../deps/mpg123/src/libmpg123/parse.c:1149:63: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(VERBOSE3) debug3("resync try %li at %"OFF_P", got newhead 0x%08lx", try, (off_p)fr->rd->tell(fr), newhead); ^ CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/frame.o ../deps/mpg123/src/libmpg123/frame.c: In function ‘INT123_frame_buffers’: ../deps/mpg123/src/libmpg123/frame.c:285:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(2*2*0x110*sizeof(real) > buffssize) ^ CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/format.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/dct64.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/equalizer.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/id3.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/optimize.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/readers.o ../deps/mpg123/src/libmpg123/readers.c: In function ‘plain_read’: ../deps/mpg123/src/libmpg123/readers.c:60:61: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(VERBOSE3) debug2("read %li bytes of %li", (long)ret, (long)count); ^ ../deps/mpg123/src/libmpg123/readers.c: In function ‘bc_add’: ../deps/mpg123/src/libmpg123/readers.c:630:15: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(size >=4) debug4("first bytes: %02x %02x %02x %02x", data[0], data[1], data[2], data[3]); ^ ../deps/mpg123/src/libmpg123/readers.c: In function ‘bc_forget’: ../deps/mpg123/src/libmpg123/readers.c:728:7: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] else debug("forget with nothing there!"); ^ ../deps/mpg123/src/libmpg123/readers.c: In function ‘INT123_feed_more’: ../deps/mpg123/src/libmpg123/readers.c:763:61: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(VERBOSE3) debug("feed_more"); ^ ../deps/mpg123/src/libmpg123/readers.c:772:82: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] (unsigned long)fr->rdat.buffer.last->size, (unsigned long)fr->rdat.buffer.size); ^ ../deps/mpg123/src/libmpg123/readers.c: In function ‘buffered_fullread’: ../deps/mpg123/src/libmpg123/readers.c:848:63: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(VERBOSE3) debug1("buffered_fullread: buffering %li bytes from stream (if > 0)", (long)got); ^ ../deps/mpg123/src/libmpg123/readers.c:856:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(got < sizeof(readbuf)) /* That naturally catches got == 0, too. */ ^ ../deps/mpg123/src/libmpg123/readers.c:867:61: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] if(VERBOSE3) debug2("wanted %li, got %li", (long)count, (long)gotcount); ^ CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/tabinit.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/libmpg123.o ../deps/mpg123/src/libmpg123/libmpg123.c: In function ‘mpg123_plain_strerror’: ../deps/mpg123/src/libmpg123/libmpg123.c:1581:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(errcode >= 0 && errcode < sizeof(mpg123_error)/sizeof(char*)) ^ CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/index.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/stringbuf.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/icy.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/icy2utf8.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/ntom.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_8bit.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/layer1.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/layer2.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/layer3.o ../deps/mpg123/src/libmpg123/layer3.c: In function ‘III_dequantize_sample’: ../deps/mpg123/src/libmpg123/layer3.c:804:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:818:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:842:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:890:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:1021:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:1036:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:1059:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ ../deps/mpg123/src/libmpg123/layer3.c:1088:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] REFRESH_MASK; ^ CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/feature.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/dct64_x86_64.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/dct64_x86_64_float.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_s32.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_real.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64_float.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64_s32.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64_s32.o CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64_float.o AR(target) Release/obj.target/deps/mpg123/libmpg123.a COPY Release/libmpg123.a CC(target) Release/obj.target/lamevectorroutines/deps/lame/libmp3lame/vector/xmm_quantize_sub.o ../deps/lame/libmp3lame/vector/xmm_quantize_sub.c: In function ‘fht_SSE2’: ../deps/lame/libmp3lame/vector/xmm_quantize_sub.c:172:20: warning: variable ‘v_s2’ set but not used [-Wunused-but-set-variable] __m128 v_s2; ^ AR(target) Release/obj.target/deps/lame/liblamevectorroutines.a COPY Release/liblamevectorroutines.a CXX(target) Release/obj.target/bindings/src/bindings.o In file included from ../src/bindings.cc:17:0: /home/q2dg/.node-gyp/0.11.14/deps/v8/include/v8.h: In function ‘void nodelame::Initialize(v8::Handle<v8::Object>)’: /home/q2dg/.node-gyp/0.11.14/deps/v8/include/v8.h:816:41: error: ‘v8::HandleScope::HandleScope()’ is protected V8_INLINE HandleScope() {} ^ ../src/bindings.cc:29:15: error: within this context HandleScope scope; ^ make: *** [Release/obj.target/bindings/src/bindings.o] Error 1 make: Leaving directory/home/q2dg/node_modules/lame/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/q2dg/node/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.emit (events.js:110:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:1059:12)
gyp ERR! System Linux 3.17.2-200.fc20.x86_64
gyp ERR! command "node" "/home/q2dg/node/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/q2dg/node_modules/lame
gyp ERR! node -v v0.11.14
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok