Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The option for connecting with TLS should be "protocol" #13

Closed
oskiwowwow opened this issue May 5, 2016 · 1 comment
Closed

The option for connecting with TLS should be "protocol" #13

oskiwowwow opened this issue May 5, 2016 · 1 comment

Comments

@oskiwowwow
Copy link

README.md says to set secureProxy to true if you want to connect to the proxy with TLS. I think it should be "protocol: 'https'" instead. secureProxy seems to be an internal variable which is set based on the value of "protocol", not the other way around.
@TooTallNate
Copy link
Owner

Good catch! Patch to fix the documentation welcome

@stoically stoically mentioned this issue Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TooTallNate @oskiwowwow