Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code formatting and repo structure #13

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

rschouten97
Copy link
Contributor

@rschouten97 rschouten97 commented Sep 3, 2024

This refactor also addresses the following issues:

  1. E-mail is always being updated #7
  2. fieldmapping missing #10
  3. 404 exception doesn't get caught, results in error. #12

The updates have been tested in a client environment and are now live at a client.

@JeroenBL JeroenBL added the needs-review Indicates that the PR is ready and waiting for review label Sep 5, 2024
@rhouthuijzen rhouthuijzen self-assigned this Sep 17, 2024
Copy link

@rhouthuijzen rhouthuijzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ziet er goed strak en herkenbaar uit. Zou je wel wil vragen om dus nog iets te doen met de write-verbose headers/token te doen.

En nog twee file namen:
-supPermissions.ps1 aanpassen naar subPermissions.ps1
-resourceCreation.ps1 naar resource.ps1

Message = "Correlated account with username $($correlatedAccount.UserName) on field $($correlationField) with value $($correlationValue)"
IsError = $false
})
Write-Verbose "Created headers. Result: $($headers | ConvertTo-Json)."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header printen zou ik niet meer doen. Je hebt hem wel weg gehaald uit de write-verbose splat (geld voor alle scripts)

ContentType = "application/json;charset=utf-8"
UseBasicParsing = $true
}
Write-Verbose "Created access token. Result: $($createAccessTokenResonse | ConvertTo-Json)"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit zou ik vervolgens ook weghalen denk ik? (geld ook voor elk script)

@rhouthuijzen rhouthuijzen added pending-author-update PR is waiting for the author to make necessary modifications or updates and removed needs-review Indicates that the PR is ready and waiting for review labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-author-update PR is waiting for the author to make necessary modifications or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 exception doesn't get caught, results in error. fieldmapping missing E-mail is always being updated
3 participants