-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code formatting and repo structure #13
base: main
Are you sure you want to change the base?
Conversation
…tDepartment and setManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code ziet er goed strak en herkenbaar uit. Zou je wel wil vragen om dus nog iets te doen met de write-verbose headers/token te doen.
En nog twee file namen:
-supPermissions.ps1 aanpassen naar subPermissions.ps1
-resourceCreation.ps1 naar resource.ps1
Message = "Correlated account with username $($correlatedAccount.UserName) on field $($correlationField) with value $($correlationValue)" | ||
IsError = $false | ||
}) | ||
Write-Verbose "Created headers. Result: $($headers | ConvertTo-Json)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Header printen zou ik niet meer doen. Je hebt hem wel weg gehaald uit de write-verbose splat (geld voor alle scripts)
ContentType = "application/json;charset=utf-8" | ||
UseBasicParsing = $true | ||
} | ||
Write-Verbose "Created access token. Result: $($createAccessTokenResonse | ConvertTo-Json)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit zou ik vervolgens ook weghalen denk ik? (geld ook voor elk script)
This refactor also addresses the following issues:
The updates have been tested in a client environment and are now live at a client.