Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php 8.1 support #25

Closed
foresight-developers opened this issue Jan 19, 2023 · 6 comments · Fixed by #32
Closed

Add php 8.1 support #25

foresight-developers opened this issue Jan 19, 2023 · 6 comments · Fixed by #32
Labels
help wanted Extra attention is needed

Comments

@foresight-developers
Copy link
Contributor

Currently experience this error:

PHP Fatal error: During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Http\Request::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php:637
Stack trace:
#0 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php(20): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError()
#1 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(578): include('...')
#2 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(432): Composer\Autoload\ClassLoader::Composer\Autoload{closure}()
#3 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php(31): Composer\Autoload\ClassLoader->loadClass()
#4 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php(332): Illuminate\Foundation\Bootstrap\SetRequestForConsole->bootstrap()
#5 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php(223): Orchestra\Testbench\TestCase->resolveApplicationBootstrappers()
#6 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase.php(73): Orchestra\Testbench\TestCase->createApplication()
#7 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns/Testing.php(79): Orchestra\Testbench\TestCase->refreshApplication()
#8 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase.php(41): Orchestra\Testbench\TestCase->setUpTheTestEnvironment()
#9 /home/runner/work/baum/baum/tests/Baseline/UnitAbstract.php(14): Orchestra\Testbench\TestCase->setUp()
#10 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCase.php(1147): Baum\Tests\Baseline\UnitAbstract->setUp()
#11 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestResult.php(728): PHPUnit\Framework\TestCase->runBare()
#12 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCase.php(904): PHPUnit\Framework\TestResult->run()
#13 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestCase->run()
#14 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestSuite->run()
#15 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSuite.php(675): PHPUnit\Framework\TestSuite->run()
#16 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(653): PHPUnit\Framework\TestSuite->run()
#17 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.php(144): PHPUnit\TextUI\TestRunner->run()
#18 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.php(97): PHPUnit\TextUI\Command->run()
#19 /home/runner/work/baum/baum/vendor/phpunit/phpunit/phpunit(98): PHPUnit\TextUI\Command::main()
#20 /home/runner/work/baum/baum/vendor/bin/phpunit(123): include('...')
#21 {main} in /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Request.php on line 20
..
In Request.php line 20:

During inheritance of ArrayAccess: Uncaught ErrorException: Return type of
Illuminate\Http\Request::offsetExists($offset) should either be compatible
with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWi
llChange] attribute should be used to temporarily suppress the notice in /h
ome/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http/Requ
est.php:637
Stack trace:
#0 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Http
/Request.php(20): Illuminate\Foundation\Bootstrap\HandleExceptions->handleE
rror()
#1 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(578): includ
e('...')
#2 /home/runner/work/baum/baum/vendor/composer/ClassLoader.php(432): Compos
er\Autoload\ClassLoader::Composer\Autoload{closure}()
#3 /home/runner/work/baum/baum/vendor/laravel/framework/src/Illuminate/Foun
dation/Bootstrap/SetRequestForConsole.php(31): Composer\Autoload\ClassLoade
r->loadClass()
#4 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/CreatesApplication.php(332): Illuminate\Foundation\Bootstrap\SetRequestFor
Console->bootstrap()
#5 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/CreatesApplication.php(223): Orchestra\Testbench\TestCase->resolveApplicat
ionBootstrappers()
#6 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase
.php(73): Orchestra\Testbench\TestCase->createApplication()
#7 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/Concerns
/Testing.php(79): Orchestra\Testbench\TestCase->refreshApplication()
#8 /home/runner/work/baum/baum/vendor/orchestra/testbench-core/src/TestCase
.php(41): Orchestra\Testbench\TestCase->setUpTheTestEnvironment()
#9 /home/runner/work/baum/baum/tests/Baseline/UnitAbstract.php(14): Orchest
ra\Testbench\TestCase->setUp()
#10 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCa
se.php(1147): Baum\Tests\Baseline\UnitAbstract->setUp()
#11 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestRe
sult.php(728): PHPUnit\Framework\TestCase->runBare()
#12 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestCa
se.php(904): PHPUnit\Framework\TestResult->run()
#13 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestCase->run()
#14 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestSuite->run()
#15 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/Framework/TestSu
ite.php(675): PHPUnit\Framework\TestSuite->run()
#16 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/TestRunne
r.php(653): PHPUnit\Framework\TestSuite->run()
#17 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.p
hp(144): PHPUnit\TextUI\TestRunner->run()
#18 /home/runner/work/baum/baum/vendor/phpunit/phpunit/src/TextUI/Command.p
hp(97): PHPUnit\TextUI\Command->run()
#19 /home/runner/work/baum/baum/vendor/phpunit/phpunit/phpunit(98): PHPUnit
\TextUI\Command::main()
#20 /home/runner/work/baum/baum/vendor/bin/phpunit(123): include('...')
#21 {main}
@foresight-developers foresight-developers added the help wanted Extra attention is needed label Jan 19, 2023
@bkintanar
Copy link
Contributor

@foresight-developers do you have any updates on this issue, do you still require help solving it?

@foresight-developers
Copy link
Contributor Author

@bkintanar our development team is currently working on some internal projects and will allocate time to this prior to php 8's support being fully dropped later this year.

That being said we would appreciate any work put towards this in the mean time.

@bkintanar bkintanar mentioned this issue Feb 15, 2023
Merged
@foresight-developers
Copy link
Contributor Author

@bkintanar I just approved and ran the github actions checks and they have failed, let me know if you need any help with that and I'll see if we can get some development time allocated internally.

@bkintanar
Copy link
Contributor

@foresight-developers I've tested it locally with 7.4, 8.0, and 8.1 and I've updated my PR. Can you approve again please?

@bkintanar
Copy link
Contributor

@foresight-developers test is still failing even though it's just a warning for P8.1

@foresight-developers
Copy link
Contributor Author

@bkintanar we can update the github actions test to ignore that warning I think, we will look into that shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 8.1 Support bkintanar/baum
2 participants
@bkintanar @foresight-developers