Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PyBind11 License #20

Closed
Teschl opened this issue May 8, 2024 · 1 comment · Fixed by #21
Closed

Handle PyBind11 License #20

Teschl opened this issue May 8, 2024 · 1 comment · Fixed by #21
Assignees
Labels
build documentation Improvements or additions to documentation

Comments

@Teschl
Copy link
Contributor

Teschl commented May 8, 2024

Since PyBind11 is using a BSD-style license that, among other things, states:

"2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution."
from pybind11 license

Does that mean we also have to include the license in our repository? If so, we'll probably need to check all other dependencies for similar requirements.

@wkearn wkearn self-assigned this May 10, 2024
@wkearn
Copy link
Contributor

wkearn commented May 10, 2024

I think you are probably right: we need to provide the pybind11 license somewhere in the package that we ship to users. It seems like scipy does this with a separate LICENSES_bundled.txt that includes the license for all of their dependencies, which seems like a good enough solution for the moment. I'll submit a PR momentarily with that file.

I think pybind11 is the only one we need to worry about at the moment because we don't distribute source or binary artifacts of any of the other dependencies (matplotlib, rasterio, etc.). pip pulls those in for the user.

@wkearn wkearn added documentation Improvements or additions to documentation build labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants