Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try_parse with std::string_view #269

Open
Paulanerus opened this issue Aug 20, 2024 · 1 comment
Open

try_parse with std::string_view #269

Paulanerus opened this issue Aug 20, 2024 · 1 comment

Comments

@Paulanerus
Copy link

Is there a reason why try_parse or parse in general doesn't work with std::string_view?

As far as i know are std::string_views's supported as values or am i missing some hint in the docs?

Thanks in advance

@Paulanerus
Copy link
Author

So I've looked a bit into your code for that and it could be as simple as wrapping the code into a string which would be okay but doesn't really fit with the string_view philosophy imo. To make use of the string_view some more changes need to be done and i don't know if this is something you allow as a pr or you are already working on that.

best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant