Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the UIStyle causes slower performance on Win32 and Linux_ARM #217

Closed
VicMisael opened this issue Nov 26, 2020 · 8 comments
Closed
Assignees
Labels
bug Something isn't working high Linux ARM Issue related to the platform Linux ARM Windows Issue related to the platform Windows
Milestone

Comments

@VicMisael
Copy link
Collaborator

VicMisael commented Nov 26, 2020

Issue Title

Changing the UIStyle causes slower performance on Win32

Describe the bug

Changing The UIStyle from Material_ui to android_ui causes slower performance when compiled to win32

To Reproduce

Pull this repository
https://github.com/TotalCross/TcTest
Set UI_Style to MATERIAL_UI

setUIStyle(Settings.MATERIAL_UI);

package for windows

test and see how much time it takes,then do all these steps again but with UI_style set to android

setUIStyle(Settings.ANDROID_UI);

Expected behavior

The test should take the same time on both

Screenshots or videos

image

Devices:

Please complete the following information:

  • Device: PC
  • OS: Windows
  • OS Version: 10 x64
  • TotalCross Version: Master(Also on 6.1.1)
@VicMisael VicMisael added bug Something isn't working Windows Issue related to the platform Windows labels Nov 26, 2020
@brunoamuniz
Copy link

Did you try on linux arm and android, too? What was the results?

@VicMisael
Copy link
Collaborator Author

VicMisael commented Nov 27, 2020

I've tried on Linux arm, here are the results
image
About 3 minutes
Using android_ui, the application ran for more than 10 minutes and had no results

@VicMisael VicMisael added the Linux ARM Issue related to the platform Linux ARM label Nov 27, 2020
@VicMisael VicMisael changed the title Changing the UIStyle causes slower performance on Win32 Changing the UIStyle causes slower performance on Win32 and Linux_ARM Dec 8, 2020
@VicMisael
Copy link
Collaborator Author

Should we deprecated ANDROID_UI? @flsobral , @teras , @ricardobna

@teras
Copy link
Collaborator

teras commented Dec 8, 2020

Because it's not modern any more?
We can show an error message that "this UI is deprecated" if we want something like this.

@nmarquesin nmarquesin added this to the 7.0 milestone Dec 11, 2020
@nmarquesin
Copy link
Contributor

@teras what do you think of deprecating all UI versions but flat and material, for version 7?

@nmarquesin
Copy link
Contributor

nmarquesin commented Dec 16, 2020

The team agreed that we are going to deprecate all UIs with the exception of flat and material on version 7. @ricardobna, could you please do this task and close the issue when you have done it? :)
@VicMisael as this is not an impending issue we recommend flat UI or material UI to be used instead.

@VicMisael
Copy link
Collaborator Author

Using the nightly version seems to narrow the gap between material and Android ui styles

@teras teras assigned teras and unassigned nmarquesin and ricardobna Dec 23, 2020
@teras
Copy link
Collaborator

teras commented Dec 23, 2020

This issue has been fixed with the PR from #193

The issue will be closed.
Please feel free to re-open the issue if the problem still persists.

@teras teras closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high Linux ARM Issue related to the platform Linux ARM Windows Issue related to the platform Windows
Projects
None yet
Development

No branches or pull requests

5 participants