Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make rank names case-insensitive #3445

Closed
AfkF24 opened this issue Oct 15, 2019 · 5 comments
Closed

Suggestion: Make rank names case-insensitive #3445

AfkF24 opened this issue Oct 15, 2019 · 5 comments

Comments

@AfkF24
Copy link

AfkF24 commented Oct 15, 2019

Please explain your feature request to the best of your abilities:
Basically what the title suggests. When attempting to assign a rank to a player (eg. /t rank add AfkF24 assistant) you have to specify it in lower-case which shouldn't really matter that much.

As a side question, does townyperms.yml allow ranks to be capitalized and does that affect how ranks are displayed on /t <town> page?

@LlmDl
Copy link
Member

LlmDl commented Oct 15, 2019

I am fairly sure I did a ticket a while back that made it so you could do capitalized ranks. People were complaining that Assistants didn't match Mayors/Residents casing on the/town screen.

I'll look into making the command case insensitive.

@AfkF24
Copy link
Author

AfkF24 commented Oct 16, 2019

Just another quick question. If I change ranks in townyperms.yml to have the first letter capitalized, will it mess up any already granted ranks that players have or does the system not care about case sensitivity?

@LlmDl
Copy link
Member

LlmDl commented Oct 16, 2019

i am betting it messes it up real good, but you could test it yourself

@AfkF24
Copy link
Author

AfkF24 commented Oct 16, 2019

Yeah, changing the capitalization via townyperms.yml just looks at it as a completely new rank, meaning that users lose their old ones. Reverting back to lower-case names works though.

@LlmDl
Copy link
Member

LlmDl commented Oct 16, 2019

Done in 462b5bb and will be a part of 0.95.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants