Remove installation test from devShell #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test requires building `nativelink`. When `nativelink` is cached, this isn't noticeable, but when changing the Rust sources this causes long wait times for flake reloads. Remove it from the devShell to prevent such rebuilds. The test is still runnable and tested in CI via `nix run .#nativelink-is-executable-test`.
aaronmondal
commented
Jun 16, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / ubuntu-22.04, Publish image (waiting on @adam-singer and @allada)
allada
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @adam-singer)
aaronmondal
commented
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test requires building
nativelink. Whennativelinkis cached, this isn't noticeable, but when changing the Rust sources this causes long wait times for flake reloads. Remove it from the devShell to prevent such rebuilds. The test is still runnable and tested in CI vianix run .#nativelink-is-executable-test.This change is