Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flux to development cluster #1096

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Jul 7, 2024

Preparation for the NativeLink operator.


This change is Reviewable

Preparation for the NativeLink operator.
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@allada +@MarcusSorealheis +@adam-singer

Reviewable status: 0 of 3 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, ubuntu-22.04, windows-2022 / stable (waiting on @adam-singer, @allada, and @MarcusSorealheis)

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 3 LGTMs obtained, and 1 discussions need to be resolved (waiting on @allada and @MarcusSorealheis)


native-cli/programs/local.go line 64 at r1 (raw file):

		ctx,
		"flux",
		&components.Flux{Version: "2.3.0"},

Does this get version get duplicated in other configs we need to reference or make note of? Guess that would be the same as below.

Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-@allada -@MarcusSorealheis

Reviewable status: 1 of 1 LGTMs obtained, and 1 discussions need to be resolved


native-cli/programs/local.go line 64 at r1 (raw file):

Previously, adam-singer (Adam Singer) wrote…

Does this get version get duplicated in other configs we need to reference or make note of? Guess that would be the same as below.

This file currently acts like a "central config file" for the cluster and is the only place that manages config versions.

At some point we should probably change this to an actual dedicated config yaml file so that we can remove all the hardcoded values from Go and make config changes easier to read.

@aaronmondal aaronmondal merged commit 6a40374 into TraceMachina:main Jul 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants