-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Tekton image tag outputs to a ConfigMap #1100
Conversation
This allows watching the `nativelink-image-tags` configmap to detect changes to the images running in the cluster. Preparation for the NativeLink operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@allada +@adam-singer +@MarcusSorealheis +@blakehatch
Reviewable status: 0 of 4 LGTMs obtained, and pending CI: asan / ubuntu-22.04 (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ideally source changes will pick up a new image tag value and redeploy without having to native up && native down
?
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 LGTMs obtained (waiting on @allada, @blakehatch, and @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 LGTMs obtained (waiting on @allada and @blakehatch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ideally source changes will pick up a new image tag value and redeploy without having to
native up && native down
?
Yes. The change in this PR is the first part of that. Now, every time a new pipeline runs it'll write the image tag to a configmap that can be viewed with e.g. kubectl describe cm nativelink-image-tags
. The follow-up changes in #1088 implement the actual watching and redeploying logic.
Reviewable status: 2 of 4 LGTMs obtained (waiting on @allada and @blakehatch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 2 of 2 LGTMs obtained
This allows watching the
nativelink-image-tags
configmap to detect changes to the images running in the cluster.Preparation for the NativeLink operator.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)