Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable rustdoc autogen #1101

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

blakehatch
Copy link
Contributor

@blakehatch blakehatch commented Jul 8, 2024

Description

This fix is to temporarily disable rustdoc autogen in our docs site until we can stabilize the parser and establish rustdoc commenting standards properly in the codebase.


This change is Reviewable

Copy link
Contributor Author

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea.

The parser is fairly complex and fixing bugs "on-the-fly" while changing things in nativelink-configs is kind of a concious design choice. Essentially, the parser and the way we write docs need to be done in sync, because "freeform" writing docs would make it incredibly hard to adapt the parser to it.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / ubuntu-22.04, Remote / large-ubuntu-22.04

@blakehatch blakehatch dismissed aaronmondal’s stale review July 8, 2024 01:59

Urgent matter with customer demo

@blakehatch blakehatch merged commit 3aa4f94 into TraceMachina:main Jul 8, 2024
29 checks passed
aaronmondal added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants