-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Http2 flags for advanced configurations #365
Conversation
Some users will want to tune advanced http2 configurations. This PR gives that ability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @blakehatch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @allada)
cas/cas_main.rs
line 467 at r1 (raw file):
if let Some(value) = http_config.http2_max_header_list_size { http.http2_max_header_list_size(value); }
Would just need another case for the http2_only method here if adding it is of interest.
config/cas_server.rs
line 212 at r1 (raw file):
/// specified. #[derive(Deserialize, Debug, Default)] pub struct HttpServerConfig {
https://docs.rs/hyper/latest/hyper/server/conn/struct.Http.html#method.http2_only
Only method in the crate not currently supported by this config is http2_only, not necessary for feature completeness here but restricting to just http2 could maybe have it's uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @blakehatch)
cas/cas_main.rs
line 467 at r1 (raw file):
Previously, blakehatch (Blake Hatch) wrote…
Would just need another case for the http2_only method here if adding it is of interest.
I thought about it, but decided that it's unlikely to ever be used.
config/cas_server.rs
line 212 at r1 (raw file):
Previously, blakehatch (Blake Hatch) wrote…
https://docs.rs/hyper/latest/hyper/server/conn/struct.Http.html#method.http2_only
Only method in the crate not currently supported by this config is http2_only, not necessary for feature completeness here but restricting to just http2 could maybe have it's uses.
(see above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @allada)
cas/cas_main.rs
line 467 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
I thought about it, but decided that it's unlikely to ever be used.
Done
config/cas_server.rs
line 212 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
(see above)
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @allada)
Some users will want to tune advanced http2 configurations. This PR gives that ability.
Some users will want to tune advanced http2 configurations. This PR gives that ability.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)