Fix never looping loops

[aaronmondal]

Clippy complained with never_loop, and indeed these loops never loop.

---

This change is 

[allada]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @aaronmondal)

---

cas/store/tests/filesystem_store_test.rs line 312 at r1 (raw file):

        while let Some(temp_dir_entry) = read_dir_stream.next().await {
            if let Ok(dir_entry) = temp_dir_entry {

I don't think we can do it this way. If temp_dir_entry had an error the test would pass.

I think you can also resolve this by using return Err(make_input_error!("No files should exist in temp directory, found {:?}", ...));

Instead.

[aaronmondal]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @allada)

---

cas/store/tests/filesystem_store_test.rs line 312 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

I don't think we can do it this way. If temp_dir_entry had an error the test would pass.

I think you can also resolve this by using return Err(make_input_error!("No files should exist in temp directory, found {:?}", ...));

Instead.

Updated this. A bit verbose, but a temp_dir_entry? doesn't work.

[allada]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)

---

cas/store/tests/filesystem_store_test.rs line 312 at r1 (raw file):

Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…

Updated this. A bit verbose, but a temp_dir_entry? doesn't work.

Yeah that is pretty verbose :-(