New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerifyStore should support Blake3 #444

Closed

allada opened this issue Dec 5, 2023 · 1 comment · Fixed by #575

Assignees

Labels

bug good first issue

Member

allada commented Dec 5, 2023

Currently VerifyStore is Sha256 specific. We should make this store support different digest functions.

see: #191 (comment)
and:
https://github.com/TraceMachina/native-link/blob/f9e537c3f9b5656be6251902640ff003a5b8cc48/native-link-store/src/verify_store.rs#L140

allada added bug good first issue labels

Contributor

steedmicro commented Dec 5, 2023

I'd like to work on this issue.

aaronmondal assigned steedmicro

allada mentioned this issue

Blake3 doesn't work out of the box #566

Closed

steedmicro mentioned this issue

Add Blake3 support for Verify Store #575

Merged

5 tasks

steedmicro closed this as completed in #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment