Fix MacOS tests #449
Fix MacOS tests #449
Conversation
These didn't work due to issues with bash/echo on MacOS.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @adam-singer and @blakehatch)
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @adam-singer, @blakehatch, and @MarcusSorealheis)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
|
Did someone run this on Mac OS? Looks good based on docs. |
|
One thing that makes Mac's a bit trickier is the default shell is zsh, though most people move to Bash in this world. |
|
@MarcusSorealheis confirmed I ran this on Mac with both bazel and cargo, I have also changed my default shell to bash. Confirmed that default shell being bash or zsh these tests now pass, thanks @aaronmondal ! |
|
Wow, amazing. Thanks for confirming. I figured you were thorough. I'm naturally a skeptic. |
These didn't work due to issues with bash/echo on MacOS.
This change is