-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove caching from native cargo action #458
Conversation
If we share caches between workflows, the runners run out of storage. If we separate the caches we have too many of them and keep stepping over GitHub's cache limitations. Remove caching entirely as this workflows doesn't take *that* long and we need the caches for Bazel and Nix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @aaronmondal)
-- commits
line 4 at r1:
shall we instead just pay for more storage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @allada)
Previously, allada (Nathan (Blaise) Bruer) wrote…
shall we instead just pay for more storage?
I think at this point it makes sense to use larger runners. We can't increase the size of the GHA cache, but e.g. having 4 or 8 cores and a few gigs more ram and storage would obsolete any cache issues we have at the moment since things would build fast enough from scratch that we don't need caching anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
I think at this point it makes sense to use larger runners. We can't increase the size of the GHA cache, but e.g. having 4 or 8 cores and a few gigs more ram and storage would obsolete any cache issues we have at the moment since things would build fast enough from scratch that we don't need caching anymore.
Crazy you can't pay for more storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
If we share caches between workflows, the runners run out of storage. If we separate the caches we have too many of them and keep stepping over GitHub's cache limitations. Remove caching entirely as this workflows doesn't take that long and we need the caches for Bazel and Nix.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)