-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves custom crates to nativelink dirs for disambiguation #483
Moves custom crates to nativelink dirs for disambiguation #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, occurrences of proto::
and error::
need to be changed to nativelink_proto::
and nativelink_error::
.
Reviewable status: 0 of 31 files reviewed, all discussions resolved
86170c4
to
c3f4c38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed this
Reviewable status: 0 of 110 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I thinkg you need to run
bazel run \
--@rules_rust//:rustfmt.toml=//:.rustfmt.toml \
@rules_rust//:rustfmt
To reorder the imports.
Reviewed 30 of 31 files at r1, 80 of 80 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)
-- commits
line 2 at r2:
nit: Try to remember to capitalize the initial letter and remove the trailing period on merge.
c3f4c38
to
7548c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 79 of 79 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
769127a
to
fabc2b3
Compare
fabc2b3
to
1419c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to merge this. Ignore the failing proto test. I can send a fix for that immediately after this PR is merged.
Reviewed 6 of 14 files at r4, 1 of 8 files at r5, 1 of 1 files at r6, 4 of 4 files at r7, all commit messages.
Reviewable status: 126 of 132 files reviewed, all discussions resolved (waiting on @allada)
Description
Two crates,
error
andproto
needed to be moved into nativelink specific dirs.Type of change
Rename
not work as expected)
Checklist
git amend
see some docsThis change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)