Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty digests not handled properly #498

Closed
allada opened this issue Dec 17, 2023 · 1 comment
Closed

Empty digests not handled properly #498

allada opened this issue Dec 17, 2023 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@allada
Copy link
Member

allada commented Dec 17, 2023

We don't quite follow remote execution spec here:

// Servers MUST behave as though empty blobs are always available, even if they

The easiest way to handle this would probably be to simply check/upload an empty digest of every support digest hash function at startup.

Finding the right place to put this feature seems a bit more complicated.

@allada allada added the enhancement New feature or request label Dec 17, 2023
@allada allada changed the title Handle empty digests better Empty digests not handled properly Dec 17, 2023
@allada allada added bug Something isn't working good first issue Good for newcomers and removed enhancement New feature or request labels Dec 17, 2023
@adam-singer adam-singer self-assigned this Dec 18, 2023
@adam-singer
Copy link
Contributor

@allada can we implement the defaulting logic of empty digests in https://github.com/adam-singer/native-link/blob/e1c495fa68b5d85872c98f9231689da4581161b1/nativelink-util/src/store_trait.rs#L43 with is_empty_digest and proceed to return successful responses before calling the underlying store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants