-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the Max Blocking Threads #510
Increase the Max Blocking Threads #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @MarcusSorealheis)
src/bin/cas.rs
line 668 at r1 (raw file):
let mut cfg = futures::executor::block_on(get_config())?; let mut metrics_enabled = {
nit: ... and extract it here.
src/bin/cas.rs
line 703 at r1 (raw file):
.unwrap_or(ConfigDigestHashFunction::sha256), ))?; !global_cfg.disable_metrics
nit: ... You can pass it here ... ^^^ (above)
src/bin/cas.rs
line 710 at r1 (raw file):
} let server_start_time = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs(); let max_open_files = if let Some(global_cfg) = &cfg.global {
nit: We have this value already here: global_cfg.max_open_files
. You can pass it ^^^ (above)
0ae5b1c
to
c469348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)
src/bin/cas.rs
line 703 at r2 (raw file):
.unwrap_or(ConfigDigestHashFunction::sha256), ))?; (!global_cfg.disable_metrics, global_cfg.max_open_files * 10)
nit: Please add a comment above this referencing a bug and why we do this magic * 10
.
c469348
to
61123e8
Compare
61123e8
to
b285c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temp fix to: #513
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
Description
Looking to implement an idea from Blaise. I need to add a test.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)