Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Max Blocking Threads #510

Merged

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Dec 19, 2023

Description

Looking to implement an idea from Blaise. I need to add a test.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @MarcusSorealheis)


src/bin/cas.rs line 668 at r1 (raw file):

    let mut cfg = futures::executor::block_on(get_config())?;

    let mut metrics_enabled = {

nit: ... and extract it here.


src/bin/cas.rs line 703 at r1 (raw file):

                .unwrap_or(ConfigDigestHashFunction::sha256),
        ))?;
        !global_cfg.disable_metrics

nit: ... You can pass it here ... ^^^ (above)


src/bin/cas.rs line 710 at r1 (raw file):

    }
    let server_start_time = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
    let max_open_files = if let Some(global_cfg) = &cfg.global {

nit: We have this value already here: global_cfg.max_open_files. You can pass it ^^^ (above)

@MarcusSorealheis MarcusSorealheis force-pushed the bump-max-blocking-threads branch from 0ae5b1c to c469348 Compare December 19, 2023 07:15
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)


src/bin/cas.rs line 703 at r2 (raw file):

                .unwrap_or(ConfigDigestHashFunction::sha256),
        ))?;
        (!global_cfg.disable_metrics, global_cfg.max_open_files * 10)

nit: Please add a comment above this referencing a bug and why we do this magic * 10.

@MarcusSorealheis MarcusSorealheis force-pushed the bump-max-blocking-threads branch from c469348 to 61123e8 Compare December 19, 2023 07:21
@MarcusSorealheis MarcusSorealheis force-pushed the bump-max-blocking-threads branch from 61123e8 to b285c17 Compare December 19, 2023 07:28
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp fix to: #513

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

@MarcusSorealheis MarcusSorealheis merged commit 6d07a86 into TraceMachina:main Dec 19, 2023
3 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants