Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale back use of async-trait where applicable #620

Closed
aaronmondal opened this issue Jan 19, 2024 · 1 comment · Fixed by #1055
Closed

Scale back use of async-trait where applicable #620

aaronmondal opened this issue Jan 19, 2024 · 1 comment · Fixed by #1055
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aaronmondal
Copy link
Member

Since Rust 1.75.0 the language has native support for async fn in Traits for some usecases (https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html).

Dynamic dispatch isn't supported yet (https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html#dynamic-dispatch), meaning that a full removal of the async-trait dependency might not be possible at this point.

However, I believe that some uses of aysnc-trait in the NativeLink codebase have become redundant. Removing them is a reduction in complexity and a potential performance improvement.

@aaronmondal aaronmondal added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2024
@adam-singer
Copy link
Contributor

cc: Assigned to @jhpratt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants