Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add Rustup to the README #648

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Feb 1, 2024

Description

In the beginning, there were clear instructions for users that had the problems addressed by NativeLink but were not necessarily Rust users. Rust is an implementation detail and Rust knowledge cannot be a pre-requisite.

Fixes # (issue)

Type of change

Getting started ticket

  • This change requires a documentation update

How Has This Been Tested?

User interviews

Checklist

  • Updated documentation if needed
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

In the beginning, there were clear instructions for users that had the problems addressed by NativeLink but were not necessarily Rust users. Rust is an implementation detail and Rust knowledge cannot be a pre-requisite.
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview Feb 1, 2024 2:20am

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@MarcusSorealheis MarcusSorealheis removed the request for review from blakehatch February 2, 2024 03:02
@MarcusSorealheis MarcusSorealheis merged commit 0cba4fa into main Feb 2, 2024
25 checks passed
@MarcusSorealheis MarcusSorealheis deleted the getting-started-rustup-returns branch February 2, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants