Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to CompletenessCheckingStore #882

Merged

Conversation

allada
Copy link
Member

@allada allada commented Apr 25, 2024

CompletenessCheckingStore will now publish metrics about the underlying store.

towards: #650


This change is Reviewable

Copy link
Member Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@blakehatch

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @blakehatch)

@allada allada force-pushed the add-completeness-checking-store-metrics branch from 51de2ec to 46f4be3 Compare April 26, 2024 01:27
Copy link
Contributor

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Remote / large-ubuntu-22.04

CompletenessCheckingStore will now publish metrics about the
underlying store.

towards: TraceMachina#650
@allada allada force-pushed the add-completeness-checking-store-metrics branch from 46f4be3 to 48af731 Compare April 26, 2024 15:01
@allada allada merged commit 520b762 into TraceMachina:main Apr 26, 2024
24 checks passed
chinchaun pushed a commit to chinchaun/nativelink that referenced this pull request May 6, 2024
CompletenessCheckingStore will now publish metrics about the
underlying store.

towards: TraceMachina#650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants