Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trivially bumpable deps #914

Merged
merged 1 commit into from
May 15, 2024

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented May 14, 2024

One noteworthy change is that this bumps the aws-sdk-s3 BehaviorVersion from 2023_11_09 to 2024_03_28. The change here is:

Deprecated since 1.4.0: Superceded by v2024_03_28, which enabled
stalled stream protection for uploads (request bodies) by default.

This change is Reviewable

Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@allada +@adam-singer

Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @adam-singer and @allada)

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and pending CI: Cargo Dev / macos-13 (waiting on @adam-singer)

Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-@adam-singer

Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Cargo Dev / macos-13

One noteworthy change is that this bumps the `aws-sdk-s3`
BehaviorVersion from `2023_11_09` to `2024_03_28`. The change here is:

```
Deprecated since 1.4.0: Superceded by v2024_03_28, which enabled
stalled stream protection for uploads (request bodies) by default.
```
@aaronmondal aaronmondal force-pushed the bump-trivially-bumpable branch from 853b955 to 82e16ea Compare May 14, 2024 18:40
@aaronmondal aaronmondal enabled auto-merge (squash) May 14, 2024 18:40
@aaronmondal aaronmondal merged commit 0ff1f45 into TraceMachina:main May 15, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants