New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folds vs upward/downward passes #3

Closed

3 tasks

khosravipasha opened this issue Apr 6, 2020 · 1 comment

Collaborator

khosravipasha commented Apr 6, 2020 •

edited

Loading

We have two versions of preresenting and iterating over circuits:

Array of nodes representation, this allows doing Pass Up/Down flow version of iterating over nodes of circuit
Just storing the root node. This way we can use the "fold" algorithms to iterate over the circuits.

Unify the queries to have both options.
Benchmark the performance of the two methods
Decide to keep/maintain both or keep one of them (I think each have their pros and cons, need to see the benchmark to decide).

khosravipasha changed the title ~~Use folds instead of upward/downward passes~~ Folds vs upward/downward passes

Collaborator Author

khosravipasha commented Jul 16, 2020

Closing this, as after recent changes this is not applicable. Going with option 2.

khosravipasha closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment