Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-smooth circuits: Bug in isstruct_decomposable, infer_vtree #47

Closed
2 tasks
khosravipasha opened this issue Oct 25, 2020 · 4 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@khosravipasha
Copy link
Collaborator

khosravipasha commented Oct 25, 2020

Update:

  • Bug in isstruct_decomposable for non-smooth circuits.
  • infer_vtree not supported for non-smooth circuits (for now throws an error)
using LogicCircuits 
using ProbabilisticCircuits 

random = load_logic_circuit(zoo_sdd_file("random.sdd"))
rand_v = zoo_vtree("random.vtree")


isstruct_decomposable(random) ## Return False
respects_vtree(random, rand_v) ## Returns True
@khosravipasha khosravipasha added the bug Something isn't working label Oct 25, 2020
@khosravipasha
Copy link
Collaborator Author

random is not smooth, that's probably why it fails. Need to add in docs what properties are needed for each function, and sometimes maybe throw error if the properties don't hold (have an option of ignoring the check for advanced cases, for example when speed is important and don't want to do the checks).

@guyvdbroeck
Copy link
Member

The answer to isstruct_decomposable(random) should be true, even if the circuit is not smooth. So this is a bug.

@khosravipasha
Copy link
Collaborator Author

khosravipasha commented Oct 28, 2020

Might also be related to: #43

Is the vtree unique if a circuit is not smooth?

@khosravipasha khosravipasha changed the title Bug in respects_vtree or isstruct_decomposable non-smooth circuits: Bug isstruct_decomposable, infer_vtree Nov 10, 2020
@khosravipasha khosravipasha changed the title non-smooth circuits: Bug isstruct_decomposable, infer_vtree non-smooth circuits: Bug in isstruct_decomposable, infer_vtree Nov 10, 2020
@khosravipasha khosravipasha added this to the Version 0.3 milestone Mar 8, 2021
@khosravipasha khosravipasha self-assigned this Mar 21, 2021
@khosravipasha khosravipasha added the enhancement New feature or request label Mar 22, 2021
@khosravipasha
Copy link
Collaborator Author

It seems smoothness is not the only issue, closing this now and tracking in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants