-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tradetrust v4 #18
Conversation
* ci: prepare alpha release * feat: oa v4 alpha * fix: lint errors * test: update fixtures * chore: update id description * test: update fixtures * chore: improve readability * fix: pr review suggestions * fix: stricter checks for isStringArray * fix: getDocumentData for v4 * chore: update getTemplateURL error message
* chore: ds store * feat: init release * chore: commit lock * feat: idvc feature * feat: idvc feature * chore: fix lint errors * feat: regenerate test fixtures for ttv4 * fix: lint errors * chore: update readme * chore: fix lint errors * feat: add additional fixtures for invalid idvc case * feat: add fixtures for error case when idvc is missing * fix: lint errors
* feat: init release (#4) * feat: trigger tagged build (#8) * feat: oa v4 (alpha) (Open-Attestation#254) * ci: prepare alpha release * feat: oa v4 alpha * fix: lint errors * test: update fixtures * chore: update id description * test: update fixtures * chore: improve readability * fix: pr review suggestions * fix: stricter checks for isStringArray * fix: getDocumentData for v4 * chore: update getTemplateURL error message * feat: idvc on v4 (#6) * chore: ds store * feat: init release * chore: commit lock * feat: idvc feature * feat: idvc feature * chore: fix lint errors * feat: regenerate test fixtures for ttv4 * fix: lint errors * chore: update readme * chore: fix lint errors * feat: add additional fixtures for invalid idvc case * feat: add fixtures for error case when idvc is missing * fix: lint errors * feat: tagged release, update badge for github actions * feat: trigger release after rebase of alpha --------- Co-authored-by: Kyle Huang Junyuan <kyle@hjunyuan.com>
* feat: point to new schemata * chore: wrong url for README * chore: lint errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
src/4.0/tt/tests/etr.test.ts|50 col 141| Insert ,
src/4.0/tt/tests/obfuscate.test.ts|98 col 38| Insert ,
src/4.0/tt/tests/obfuscate.test.ts|104 col 69| Insert ,
src/4.0/tt/tests/obfuscate.test.ts|148 col 73| Insert ,
src/4.0/tt/tests/obfuscate.test.ts|173 col 75| Insert ,
src/4.0/tt/tests/obfuscate.test.ts|206 col 75| Insert ,
src/4.0/tt/tests/salt.test.ts|151 col 113| Insert ,
src/4.0/tt/tests/salt.test.ts|153 col 45| Replace toThrowError() with its canonical name of toThrow()
src/4.0/tt/tests/salt.test.ts|158 col 117| Insert ,
src/4.0/tt/tests/sign.test.ts|18 col 141| Insert ,
src/4.0/tt/tests/sign.test.ts|23 col 89| Insert ,
src/4.0/tt/tests/sign.test.ts|28 col 13| Insert ,
src/4.0/tt/tests/sign.test.ts|33 col 141| Insert ,
src/4.0/tt/tests/sign.test.ts|44 col 8| Insert ,
src/4.0/tt/tests/sign.test.ts|51 col 9| Insert ,
src/4.0/tt/tests/sign.test.ts|58 col 100| Insert ,
src/4.0/tt/digest.ts|9 col 27| Insert ,
src/4.0/tt/obfuscate.ts|42 col 28| Insert ,
src/4.0/tt/schema/schema.test.ts|1 col 1| Definition for rule 'jest/no-try-expect' was not found.
src/4.0/tt/sign.ts|10 col 42| Insert ,
src/4.0/tt/traverseAndFlatten.ts|20 col 87| Insert ,
src/4.0/tt/types.ts|35 col 5| Insert ,
src/4.0/tt/types.ts|43 col 5| Insert ,
src/4.0/tt/validate/validate.ts|25 col 118| Insert ,
src/4.0/tt/validate/validate.ts|62 col 97| Insert ,
src/4.0/tt/validate/validate.ts|78 col 47| Insert ,
src/4.0/tt/validate/validate.ts|122 col 58| Insert ,
src/4.0/tt/wrap.ts|15 col 32| Insert ,
src/4.0/tt/wrap.ts|80 col 32| Insert ,
src/4.0/tt/wrap.ts|87 col 113| Insert ,
src/index.ts|62 col 33| Insert ,
src/index.ts|69 col 33| Insert ,
src/index.ts|76 col 33| Insert ,
src/index.ts|83 col 33| Insert ,
src/index.ts|90 col 33| Insert ,
src/index.ts|97 col 33| Insert ,
src/index.ts|130 col 27| Insert ,
src/index.ts|137 col 122| Insert ,
src/index.ts|151 col 28| Insert ,
src/index.ts|155 col 28| Insert ,
src/index.ts|178 col 42| Insert ,
src/index.ts|183 col 42| Insert ,
src/index.ts|188 col 42| Insert ,
src/shared/@types/document.ts|33 col 3| Insert ··
src/shared/@types/document.ts|34 col 1| Insert ··
src/shared/@types/document.ts|35 col 3| Insert ····
src/shared/@types/document.ts|36 col 1| Insert ····
src/shared/@types/document.ts|37 col 3| Insert ······
src/shared/@types/document.ts|38 col 1| Insert ······
src/shared/@types/document.ts|42 col 3| Insert ··
src/shared/@types/document.ts|43 col 1| Insert ··
src/shared/@types/document.ts|44 col 3| Insert ····
src/shared/@types/document.ts|45 col 1| Insert ····
src/shared/@types/document.ts|46 col 3| Insert ······
src/shared/@types/document.ts|47 col 1| Insert ······
src/shared/@types/document.ts|67 col 110| Insert ,
src/shared/utils/tests/utils.test.ts|227 col 121| Insert ,
src/shared/utils/tests/utils.test.ts|228 col 10| Insert ,
src/shared/utils/tests/utils.test.ts|284 col 114| Insert ,
src/shared/utils/tests/utils.test.ts|285 col 10| Insert ,
src/shared/utils/tests/utils.test.ts|456 col 120| Insert ,
src/shared/utils/diagnose.ts|108 col 9| Insert ,
src/shared/utils/diagnose.ts|116 col 89| Insert ,
src/shared/utils/diagnose.ts|223 col 169| Insert ,
src/shared/utils/diagnose.ts|235 col 143| Insert ,
src/shared/utils/diagnose.ts|242 col 124| Insert ,
src/shared/utils/diagnose.ts|254 col 132| Insert ,
src/shared/utils/diagnose.ts|261 col 113| Insert ,
src/shared/utils/diagnose.ts|319 col 169| Insert ,
src/shared/utils/diagnose.ts|331 col 143| Insert ,
src/shared/utils/diagnose.ts|338 col 124| Insert ,
src/shared/utils/diagnose.ts|350 col 132| Insert ,
src/shared/utils/diagnose.ts|357 col 113| Insert ,
src/shared/utils/guard.ts|49 col 52| Insert ,
src/shared/utils/guard.ts|59 col 121| Insert ,
src/shared/utils/guard.ts|77 col 52| Insert ,
src/shared/utils/guard.ts|87 col 110| Insert ,
src/shared/utils/guard.ts|117 col 52| Insert ,
src/shared/utils/guard.ts|129 col 52| Insert ,
src/shared/utils/guard.ts|140 col 52| Insert ,
src/shared/utils/guard.ts|176 col 52| Insert ,
src/shared/utils/guard.ts|188 col 52| Insert ,
src/shared/utils/utils.ts|115 col 115| Insert ,
src/shared/utils/utils.ts|126 col 115| Insert ,
src/shared/utils/utils.ts|148 col 108| Insert ,
src/shared/utils/utils.ts|162 col 116| Insert ,
src/shared/utils/utils.ts|253 col 48| Insert ,
src/shared/utils/utils.ts|275 col 48| Insert ,
src/shared/validate/validate.ts|23 col 26| Insert ,
test/fixtures/v4/tt/did-wrapped-obfuscated.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎··
with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped-obfuscated.json|90 col 22| Replace ⏎········"b38c55ee459f8cb96db13e5efd494105e98b9abee37ada37d31ae0bb1eadb73e"⏎······
with "b38c55ee459f8cb96db13e5efd494105e98b9abee37ada37d31ae0bb1eadb73e"
test/fixtures/v4/tt/did-wrapped-obfuscated.json|95 col 2| Insert ⏎
test/fixtures/v4/tt/did-wrapped-signed.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎··
with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped-signed.json|96 col 2| Insert ⏎
test/fixtures/v4/tt/did-wrapped.json|6 col 12| Replace ⏎····"VerifiableCredential",⏎····"TradeTrustCredential"⏎··
with "VerifiableCredential",·"TradeTrustCredential"
test/fixtures/v4/tt/did-wrapped.json|94 col 2| Insert ⏎
🎉 This PR is included in version 6.10.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
What is the background of this pull request?
feat: TradeTrust V4