New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header & Search UI Review #192

Open

mihneaz opened this issue Nov 20, 2019 · 2 comments

mihneaz commented Nov 20, 2019

I tested out the latest elements, here are a few minor visual bugs:

Header
- vertically center the icon
- border at the bottom
- right to left knob

Search
- border should be thinker
- hover state

lloydhumphreys commented Nov 20, 2019

Please add specifications for the border. Shadow on scroll? etc.
and hover state?

Contributor

Kian-Esmaeilpour commented May 10, 2021

Can we close this one @mihneaz or I should create a Jira ticket for it?
Example of usage in sandbox: https://sandbox.tradeshift.com/#/Tradeshift.PinnedAppsManager

Storybook:
https://tradeshift.github.io/elements/?path=/story/ts-header--default

https://tradeshift.github.io/elements/?path=/story/ts-search--default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment