Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we explictly add "A1.2.3" to the list of anatomical entities? #59

Closed
1 task done
gaurav opened this issue Sep 6, 2022 · 1 comment
Closed
1 task done
Assignees

Comments

@gaurav
Copy link
Collaborator

gaurav commented Sep 6, 2022

In the following code, A1.2.3 Fully Formed Anatomical Structure is listed as a UMLS category in the comments, but is not listed on line 77:

#UMLS categories:
#A1.2 Anatomical Structure
#A1.2.1 Embryonic Structure
#A1.2.3 Fully Formed Anatomical Structure
#A1.2.3.1 Body Part, Organ, or Organ Component
#A1.2.3.2 Tissue
#A1.2.3.3 Cell
#A1.2.3.4 Cell Component
#A2.1.4.1 Body System
#A2.1.5.1 Body Space or Junction
#A2.1.5.2 Body Location or Region
umlsmap = {x: ANATOMICAL_ENTITY for x in ['A1.2', 'A1.2.1', 'A1.2.3.1', 'A1.2.3.2', 'A2.1.4.1', 'A2.1.5.1', 'A2.1.5.2']}

According to TranslatorSRI/NodeNormalization#119 (comment), there are 41 UMLS IDs classified as A1.2.3 that are leftover at the end of processing. Adding them as anatomical entities could remove them from the UMLS generation.

Next steps:

  • Get a list of the 41 anatomical entities leftover in UMLS at the end of processing.
@gaurav gaurav self-assigned this Sep 6, 2022
@gaurav
Copy link
Collaborator Author

gaurav commented Sep 10, 2022

The 41 anatomical entities leftover in UMLS at the end of processing are (with counts):

count id url label notes
1 UMLS:C1184839 https://uts.nlm.nih.gov/uts/umls/concept/C1184839 Set of anatomical features Parent concept of Set of recesses, fossae and folds, Set of eye and related structures and Set of hepatic segmentation: lobes, parts, divisions and segments
1 UMLS:C1254346 https://uts.nlm.nih.gov/uts/umls/concept/C1254346 Fully Formed Anatomical Structure
3 UMLS:C0456626 https://uts.nlm.nih.gov/uts/umls/concept/C0456626 Whole body structures Parent concept of Whole skeleton, Whole breast, Whole liver, Whole forefoot, Whole body
4 UMLS:C1180279 https://uts.nlm.nih.gov/uts/umls/concept/C1180279 Male adult human body
4 UMLS:C1180280 https://uts.nlm.nih.gov/uts/umls/concept/C1180280 Female adult human body
8 UMLS:C0229961 https://uts.nlm.nih.gov/uts/umls/concept/C0229961 Carcass
9 UMLS:C0229960 https://uts.nlm.nih.gov/uts/umls/concept/C0229960 Entire body as a whole
11 UMLS:C1185545 https://uts.nlm.nih.gov/uts/umls/concept/C1185545 Set of parts of human body

I don't think any of these would be useful to have in Babel, so I'm going to close this issue.

@gaurav gaurav closed this as completed Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant