Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --build-arg support #91

Open
ShadowCoder22 opened this issue Jul 14, 2016 · 7 comments
Open

Add --build-arg support #91

ShadowCoder22 opened this issue Jul 14, 2016 · 7 comments
Milestone

Comments

@ShadowCoder22
Copy link

Docker allows users to pass arguments to the build command. This is useful for cases where a developer has to calculate a variable at build time. Please consider adding support for this feature.

@bjornmagnusson
Copy link
Contributor

As I see it, only reason for using this property would be when using an static/external Dockerfile. When plugin is generating the Dockerfile you already can provide properties from within you build script

@bjornmagnusson
Copy link
Contributor

Unsupported in docker-java 2.2.0 (used by plugin in master). Needs docker-java 3.0.0+, which includes breaking changes. Postpone this to an later release.

@bjornmagnusson bjornmagnusson added this to the 1.4 milestone Mar 5, 2017
@gclayburg
Copy link

It would be nice to have this so that you could add build time arguments to a Dockerfile LABEL like this

docker build --build-arg VCS_REF=`git rev-parse --short HEAD` .

@chadlwilson
Copy link

Yes; or to pass parameters to other Dockerfile elements that the plugin doesn't have support for; such as HEALTHCHECK

@mklueh
Copy link

mklueh commented Dec 24, 2017

News on this? Need to disable the cache

@bjornmagnusson
Copy link
Contributor

No work has been done. It is indeed a wanted feature
We do welcome PRs.

@jainarpit6
Copy link

Any progress on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants