-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datacheck options for non-highway systems #604
Comments
The threshold for NMPs should be smaller than for highways. I don't know the hwy value nor have a proposal for railways. |
180° SA (sharp angle) errors are usually intended when there is a DC (duplicate coords) error before and after, e.g.:
I don't think that we can simply disable it via enabling/disabling but would need more logic in the data check. |
We might generally disable the LONG_UNDERSCORE data check for railway systems: TravelMapping/Web#629 (comment) |
In the OP, @jteresco wrote:
My first under-the-hood thought here is function pointers. The command-line mechanism can set a function pointer to the appropriate datacheck suite, and life goes on -- |
HIDDEN_JUNCTION and VISIBLE_HIDDEN_COLOC are also quite common for railways. Omit? |
The relevant datachecks will be different for non-highway instances of TM. Naming conventions can be different, acceptable distances between visible points might be different, etc.
It might make sense to have a command-line parameter mechanism to enable/disable various datachecks. Then the site update script can select the right ones for whichever kind of data is being used in the update.
The text was updated successfully, but these errors were encountered: