Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-edge HIDDEN_JUNCTION: hidden system & region split compatibility #663

Open
yakra opened this issue Oct 21, 2024 · 0 comments
Open

2-edge HIDDEN_JUNCTION: hidden system & region split compatibility #663

yakra opened this issue Oct 21, 2024 · 0 comments

Comments

@yakra
Copy link
Contributor

yakra commented Oct 21, 2024

https://forum.travelmapping.net/index.php?topic=4781.msg36042#msg36042

VISIBLE_HIDDEN_COLOC are naturally going to occur on border points,
with [ITA-LOM A1 LOM/EMI] colocated with [ITA A1 +LOM/EMI].

This affects 2-edge HIDDEN_JUNCTION cases too. As-is, this yields 166 FPs.
Easy fix: HighwaySegment::same_routes -> HighwaySegment::same_con_routes.
Requires minor changes to 4 lines of code.

I've made the changes locally, but will include with hidden system implementation to avoid a merge conflict.
Easy enough. Just leaving this reminder to remember to do that.


Thankfully, leaving in easy access to some debug text made it easy to spot what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant