Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan visualizer's render_memory_block_window calls render_breakdown_ui #238

Open
h3r2tic opened this issue Jul 7, 2024 · 2 comments · May be fixed by #239
Open

Vulkan visualizer's render_memory_block_window calls render_breakdown_ui #238

h3r2tic opened this issue Jul 7, 2024 · 2 comments · May be fixed by #239

Comments

@h3r2tic
Copy link

h3r2tic commented Jul 7, 2024

https://github.com/Traverse-Research/gpu-allocator/blob/main/src/vulkan/visualizer.rs#L153

It should probably call render_memory_block_ui instead :D

Cool visualizer btw! <3
@Jasper-Bekkers
Copy link
Member

Thanks! @h3r2tic Can you do a quick PR?

@h3r2tic h3r2tic linked a pull request Jul 7, 2024 that will close this issue
Open
@h3r2tic
Copy link
Author

h3r2tic commented Jul 7, 2024

Done'th, and I apparently used time travel for it.

image

Dual-booting is a gift that keeps on giving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⏹️ Fix render_memory_block_window h3r2tic/gpu-allocator
2 participants
@Jasper-Bekkers @h3r2tic