Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork /develop/ 2.1.+ branch into a new branch to create a react-native only branch #229

Closed
TreeMama opened this issue Sep 8, 2021 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation

Comments

@TreeMama
Copy link
Owner

TreeMama commented Sep 8, 2021

Per @halmueller's advice - in order to try to get the AR feature working (from #219) we are going to create a new branch - a react-native only branch.

This is a ticket to do this work.

Goal:

  1. Build a new branch in react-native only. Resolve all fatal errors. See performed "expo eject" and followup #227 for the first try.

  2. Update Readme with instructions/dependencies/and how to build info.

  3. Also included in this is making sure V2.5: Change from EXPO Camera Component to React-Native Camera Component (?) #63 and V1.02: Pixel3 user logging a 90 degree rotation on their photo #49 are good (V2.5: Change from EXPO Camera Component to React-Native Camera Component (?) #63 is an outstanding issue where we forcibly patched certain android phones with ticket V1.02: Pixel3 user logging a 90 degree rotation on their photo #49, to rotate a users image, to stop the image from showing as rotated in the database).

IMPORTANT: Before starting make sure to sync with /develop/

@halmueller suggests to make a clean start, create a new branch from develop, do the migration in a feature branch, then merge to develop.

...And then we delete feature/expo-eject as a failed experiment.

@TreeMama TreeMama changed the title fork /develop/ branch into a new branch to create a react-native only branch fork /develop/ 2.1.+ branch into a new branch to create a react-native only branch Sep 8, 2021
@halmueller
Copy link
Collaborator

Someone with Android dev tools installed can help this effort by trying to build from the feature/expo-eject branch, and take a whack at resolving what look to me to be version dependency mistakes.

@TreeMama
Copy link
Owner Author

@halmueller - for this ticket do we open another feature branch - then push into /develop/ - then push into /expo-eject/ ?

@halmueller
Copy link
Collaborator

halmueller commented Sep 15, 2021 via email

@TreeMama
Copy link
Owner Author

@halmueller
Copy link
Collaborator

halmueller commented Sep 29, 2021 via email

@TreeMama TreeMama added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Oct 11, 2021
@TreeMama
Copy link
Owner Author

As of 10/22 - we have some small bugs - but opening new tickets for them. Consider us migrated - thanks @monikap0612 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants