-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fork /develop/ 2.1.+ branch into a new branch to create a react-native only branch #229
Comments
Someone with Android dev tools installed can help this effort by trying to build from the |
@halmueller - for this ticket do we open another feature branch - then push into /develop/ - then push into /expo-eject/ ? |
No. Don’t push to develop until it’s fixed.
Easiest way would be for someone else to fix feature/expo-eject, and then merge to develop.
If instead they want a clean start, they would create a new branch from develop, do the migration, merge to develop. And then we delete feature/expo-eject as a failed experiment.
Hal
… On Sep 14, 2021, at 11:19 PM, TreeMamaSEA ***@***.***> wrote:
@halmueller - for this ticket do we open another feature branch - then push into /develop/ - then push into /expo-eject/ ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
can you PR this branch ? https://github.com/TreeMama/iSeaTree-React-Prototype/tree/feature/299 |
You (or Monika) have to create the PR (click the “Pull Requests” tab, then the green “New Pull Request” button). Then in the field in the right-hand column, request a review from me.
I just tried, but I can’t tag myself for a Code Review (CR) of my own PR.
The Pull Request is customarily created by the person who did the work (Monika, or you), and the Code Review is done by someone else (me, in this case).
Hal
… On Sep 28, 2021, at 11:15 PM, TreeMamaSEA ***@***.***> wrote:
@monikap0612
we need to be sure that this block of code is disabled for the new react-native camera component.. We don't want to rotate images anymore for /android/ devices (the assumption is we won't need to with react-native
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
As of 10/22 - we have some small bugs - but opening new tickets for them. Consider us migrated - thanks @monikap0612 ! |
Per @halmueller's advice - in order to try to get the AR feature working (from #219) we are going to create a new branch - a react-native only branch.
This is a ticket to do this work.
Goal:
Build a new branch in react-native only. Resolve all fatal errors. See performed "expo eject" and followup #227 for the first try.
Update Readme with instructions/dependencies/and how to build info.
Also included in this is making sure V2.5: Change from EXPO Camera Component to React-Native Camera Component (?) #63 and V1.02: Pixel3 user logging a 90 degree rotation on their photo #49 are good (V2.5: Change from EXPO Camera Component to React-Native Camera Component (?) #63 is an outstanding issue where we forcibly patched certain android phones with ticket V1.02: Pixel3 user logging a 90 degree rotation on their photo #49, to rotate a users image, to stop the image from showing as rotated in the database).
IMPORTANT: Before starting make sure to sync with /develop/
@halmueller suggests to make a clean start, create a new branch from develop, do the migration in a feature branch, then merge to develop.
...And then we delete feature/expo-eject as a failed experiment.
The text was updated successfully, but these errors were encountered: