Skip to content

Commit 9381909

Browse files
committed
mongodb#1930 rename arguments, keep in line with the parent name
1 parent 11b5da8 commit 9381909

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/Relations/BelongsToMany.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ protected function setWhere()
8282
}
8383

8484
/** @inheritdoc */
85-
public function save(Model $model, array $joining = [], $touch = true)
85+
public function save(Model $model, array $pivotAttributes = [], $touch = true)
8686
{
8787
$model->save(['touch' => false]);
8888

89-
$this->attach($model, $joining, $touch);
89+
$this->attach($model, $pivotAttributes, $touch);
9090

9191
return $model;
9292
}

src/Relations/EmbedsMany.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,13 @@ protected function getEmbedded()
322322
}
323323

324324
/** @inheritdoc */
325-
protected function setEmbedded($models)
325+
protected function setEmbedded($records)
326326
{
327-
if (! is_array($models)) {
328-
$models = [$models];
327+
if (! is_array($records)) {
328+
$records = [$records];
329329
}
330330

331-
return parent::setEmbedded(array_values($models));
331+
return parent::setEmbedded(array_values($records));
332332
}
333333

334334
/** @inheritdoc */

src/Schema/Blueprint.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@ public function primary($columns = null, $name = null, $algorithm = null, $optio
8181
}
8282

8383
/** @inheritdoc */
84-
public function dropIndex($indexOrColumns = null)
84+
public function dropIndex($index = null)
8585
{
86-
$indexOrColumns = $this->transformColumns($indexOrColumns);
86+
$index = $this->transformColumns($index);
8787

88-
$this->collection->dropIndex($indexOrColumns);
88+
$this->collection->dropIndex($index);
8989

9090
return $this;
9191
}
@@ -332,11 +332,11 @@ protected function fluent($columns = null)
332332
* Allows the use of unsupported schema methods.
333333
*
334334
* @param string $method
335-
* @param array $args
335+
* @param array $parameters
336336
*
337337
* @return Blueprint
338338
*/
339-
public function __call($method, $args)
339+
public function __call($method, $parameters)
340340
{
341341
// Dummy.
342342
return $this;

0 commit comments

Comments
 (0)