Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - How to use typography? #235

Closed
Tracked by #64
DamlaDemir opened this issue Sep 13, 2022 · 3 comments · Fixed by #254
Closed
Tracked by #64

Documentation - How to use typography? #235

DamlaDemir opened this issue Sep 13, 2022 · 3 comments · Fixed by #254
Assignees
@DamlaDemir
Labels
documentation Improvements or additions to documentation

Comments

@DamlaDemir
Copy link
Contributor

Heading variables (heading1, heading2, heading3) in our typography system are missing, these variables should be added. And the documentation is unsatisfactory for development. We should describe the variable names and their styles in the documentation. When looking at the documentation, typography variables and their styles should be easily found.

https://www.figma.com/file/lSvX6Qe0jc8b4CaIK7egXR/Baklava-Component-Library?node-id=240%3A124
@DamlaDemir DamlaDemir self-assigned this Sep 13, 2022
@DamlaDemir DamlaDemir added baklava-ds documentation Improvements or additions to documentation labels Sep 13, 2022
@muratcorlu
Copy link
Contributor

Linked Figma document is private. Typography rules should be moved to the public Figma document @buseselvi

@batuhantozun batuhantozun mentioned this issue Sep 13, 2022
Closed
64 tasks
@DamlaDemir DamlaDemir changed the title Adding missing typography variables and improve storybook documentation for typography Documentation - How to use typography? Sep 13, 2022
@muratcorlu
Copy link
Contributor

Looks like a duplicate of #92

@buseselvi
Copy link
Contributor

buseselvi commented Sep 16, 2022 •
edited
Loading

We added the typography document to the public Figma document: https://www.figma.com/file/RrcLH0mWpIUy4vwuTlDeKN/Baklava-Design-Guide?node-id=1564%3A6892

@DamlaDemir DamlaDemir mentioned this issue Sep 28, 2022
Merged
@muratcorlu muratcorlu linked a pull request Sep 29, 2022 that will close this issue
refactor: change typography variables and fix document #254
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamlaDemir DamlaDemir

Labels
documentation Improvements or additions to documentation
Projects
Baklava Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change typography variables and fix document Trendyol/baklava
3 participants
@muratcorlu @DamlaDemir @buseselvi